linux-kernel - Re: [PATCH v3] spi: qup: Add DMA capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54F6D24D.2050509@linaro.org>
Date:	Wed, 04 Mar 2015 11:37:17 +0200
From:	Stanimir Varbanov <stanimir.varbanov@...aro.org>
To:	"Ivan T. Ivanov" <iivanov@...sol.com>
CC:	Stanimir Varbanov <stanimir.varbanov@...aro.org>,
	Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-spi@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Kumar Gala <galak@...eaurora.org>,
	Andy Gross <agross@...eaurora.org>,
	Sagar Dharia <sdharia@...eaurora.org>,
	Daniel Sneddon <dsneddon@...eaurora.org>
Subject: Re: [PATCH v3] spi: qup: Add DMA capabilities

On 03/04/2015 10:38 AM, Ivan T. Ivanov wrote:
> 
> Hi Stan,
> 
> It looks good now, except it doesn't apply and two small issues below:
> 

<snip>

> 
>> +
>> +       /* set DMA parameters */
>> +       rx_conf->direction = DMA_DEV_TO_MEM;
>> +       rx_conf->device_fc = 1;
> 
> Strictly speeching this is a bool not int.

sure will correct.

>>
>> +       ret = spi_qup_init_dma(master, res->start);
>> +       if (ret == -EPROBE_DEFER)
>> +               goto error;
>> +       else if (!ret)
>> +               master->can_dma = spi_qup_can_dma;
>> +
>>         /* set v1 flag if device is version 1 */
>>         if (of_device_is_compatible(dev->of_node, "qcom,spi-qup-v1.1.1"))
>>                 controller->qup_v1 = 1;
> 
> It is not visible from this patch, but in case of error reseting
> SPI controller (QUP_STATE_RESET), exit error path should be 
> 'error_dma' and not 'error' label.

my fault, will correct.

regards,
Stan


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/