linux-kernel - Re: [PATCH 2/2] x86/fpu: factor out memset(xstate, 0) in fpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150304113837.GC3516@pd.tnic>
Date:	Wed, 4 Mar 2015 12:38:37 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Tavis Ormandy <taviso@...gle.com>, Ingo Molnar <mingo@...nel.org>,
	Rik van Riel <riel@...hat.com>,
	Andy Lutomirski <luto@...capital.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] x86/fpu: factor out memset(xstate, 0) in fpu_finit()
 paths

On Mon, Mar 02, 2015 at 07:32:57PM +0100, Oleg Nesterov wrote:
> fx_finit() has 2 users but only fpu_finit() needs to nullify xstate,
> alloc_bootmem_align() in setup_init_fpu_buf() returns zero-filled
> memory.
> 
> And note that both memset()'s look confusing. Yes, offsetof() is 0
> for ->fxsave or ->fsave, but it would be more clean to turn them into
> a single memset() which nullifies fpu->state.
> 
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/