linux-kernel - Re: [PATCH] dma: xilinx-dma: move header file to common location

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Mar 2015 17:32:50 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Kedareswara rao Appana <appana.durga.rao@...inx.com>,
	dan.j.williams@...el.com, michal.simek@...inx.com,
	soren.brinkmann@...inx.com, svemula@...inx.com,
	linux-kernel@...r.kernel.org, anirudh@...inx.com,
	dmaengine@...r.kernel.org, appanad@...inx.com
Subject: Re: [PATCH] dma: xilinx-dma: move header file to common location

On Mon, Mar 02, 2015 at 08:28:01PM +0100, Arnd Bergmann wrote:
> On Monday 02 March 2015 23:24:24 Kedareswara rao Appana wrote:
> > This patch moves the xilinx_dma.h header file
> > to the include/linux/dma.
> > 
> > Signed-off-by: Kedareswara rao Appana <appanad@...inx.com>
> 
> Please move this header file to drivers/dma/xilinx/ directly to
> make it inaccessible by other driver. No driver should pass extra
> data structures to a dmaengine driver.
Actually that is not true. Few of the drivers need some additional
parameters to be set which are not covered by the common set, hence an
additional API is exposed by this driver to do so...

If ever we could get rid of these...

-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/