linux-kernel - Re: [PATCH v2] cpufreq: ppc: Add missing #include <asm/smp.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 04 Mar 2015 15:22:57 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Geert Uytterhoeven <geert+renesas@...der.be>
Cc:	Viresh Kumar <viresh.kumar@...aro.org>, linux-pm@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] cpufreq: ppc: Add missing #include <asm/smp.h>

On Wednesday, March 04, 2015 12:56:20 PM Geert Uytterhoeven wrote:
> If CONFIG_SMP=n, <linux/smp.h> does not include <asm/smp.h>, causing:
> 
> drivers/cpufreq/ppc-corenet-cpufreq.c: In function 'corenet_cpufreq_cpu_init':
> drivers/cpufreq/ppc-corenet-cpufreq.c:173:3: error: implicit declaration of function 'get_hard_smp_processor_id' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> Seen with e.g. corenet64_smp_defconfig + CONFIG_CPU_FREQ=y,
> CONFIG_PPC_CORENET_CPUFREQ=y, CONFIG_SMP=n
> 
> v2:
>   - Add comment for #include directive, as requested by Viresh

Applied, thanks!

> ---
>  drivers/cpufreq/ppc-corenet-cpufreq.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/cpufreq/ppc-corenet-cpufreq.c b/drivers/cpufreq/ppc-corenet-cpufreq.c
> index bee5df7794d33d10..7cb4b766cf948d3f 100644
> --- a/drivers/cpufreq/ppc-corenet-cpufreq.c
> +++ b/drivers/cpufreq/ppc-corenet-cpufreq.c
> @@ -22,6 +22,8 @@
>  #include <linux/smp.h>
>  #include <sysdev/fsl_soc.h>
>  
> +#include <asm/smp.h>	/* for get_hard_smp_processor_id() in UP configs */
> +
>  /**
>   * struct cpu_data - per CPU data struct
>   * @parent: the parent node of cpu clock
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/