linux-kernel - Re: [PATCH 4/6] ARM: DT: STi: STiH407: Add dwc3 usb3 DT node.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54F716E7.9090406@st.com>
Date:	Wed, 4 Mar 2015 15:29:59 +0100
From:	Maxime Coquelin <maxime.coquelin@...com>
To:	Peter Griffin <peter.griffin@...aro.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <srinivas.kandagatla@...il.com>,
	<patrice.chotard@...com>, <kishon@...com>, <balbi@...com>
CC:	<lee.jones@...aro.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH 4/6] ARM: DT: STi: STiH407: Add dwc3 usb3 DT node.

Hi Peter,

On 02/25/2015 02:36 PM, Peter Griffin wrote:
> Now that both usb2 and usb3 phy drivers, and also the ST dwc3 glue code
> are all present upstream, we can add the dwc3 DT node and have a working
> usb3 controller on stih407-b2120 and stih410-b2020.
>
> Signed-off-by: Peter Griffin <peter.griffin@...aro.org>
> ---
>   arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++
>   1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> index 186412d..18ff5a5 100644
> --- a/arch/arm/boot/dts/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/stih407-family.dtsi
> @@ -7,6 +7,7 @@
>    * publishhed by the Free Software Foundation.
>    */
>   #include "stih407-pinctrl.dtsi"
> +#include <dt-bindings/phy/phy.h>
>   #include <dt-bindings/reset-controller/stih407-resets.h>
>   / {
>   	#address-cells = <1>;
> @@ -336,5 +337,30 @@
>   				resets = <&softreset STIH407_MIPHY2_SOFTRESET>;
>   			};
>   		};
> +
> +		st_dwc3: dwc3@...4000 {
> +			compatible	= "st,stih407-dwc3";
> +			reg		= <0x08f94000 0x1000>, <0x110 0x4>;
> +			reg-names	= "reg-glue", "syscfg-reg";
> +			st,syscfg	= <&syscfg_core>;
> +			resets		= <&powerdown STIH407_USB3_POWERDOWN>,
> +					  <&softreset STIH407_MIPHY2_SOFTRESET>;
> +			reset-names	= "powerdown",
> +					  "softreset";
> +			#address-cells	= <1>;
> +			#size-cells	= <1>;
> +			pinctrl-names	= "default";
> +			pinctrl-0	= <&pinctrl_usb3>;
> +			ranges;
> +
> +			dwc3: dwc3@...0000 {
> +				compatible	= "snps,dwc3";
> +				reg		= <0x09900000 0x100000>;
> +				interrupts	= <GIC_SPI 155 IRQ_TYPE_NONE>;
> +				dr_mode		= "host";
> +				phy-names	= "usb2-phy", "usb3-phy";
> +				phys		= <&usb2_picophy0>, <&phy_port2 PHY_TYPE_USB3>;
> +			};
> +		};
>   	};
>   };

The USB3 port should only be enabled in the board files, not the soc one.
We can have a board without USB3 port, so it should be disbaled by default.

Other than that, you can enable it also on stih418-b2199, just tested 
and it is working.

Thanks,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/