linux-kernel - Re: [PATCH v2] mfd: Add specific compatible strings for Qualcomm's SPMI PMIC's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1425543278.5705.11.camel@mm-sol.com>
Date:	Thu, 05 Mar 2015 10:14:38 +0200
From:	"Ivan T. Ivanov" <iivanov@...sol.com>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Lee Jones <lee.jones@...aro.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Stanimir Varbanov <svarbanov@...sol.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v2] mfd: Add specific compatible strings for Qualcomm's
 SPMI PMIC's


On Wed, 2015-03-04 at 11:01 -0800, Stephen Boyd wrote:
> On 03/04/15 02:19, Ivan T. Ivanov wrote:
> > diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c
> > index 4b8beb2..a1af4e5 100644
> > --- a/drivers/mfd/qcom-spmi-pmic.c
> > +++ b/drivers/mfd/qcom-spmi-pmic.c
> > 
> > +
> > +static void pmic_spmi_show_revid(struct regmap *map, struct device *dev)
> > +{
> > +       unsigned int rev2, minor, major, type, subtype;
> > +       int ret;
> > +
> > +       ret = regmap_read(map, PMIC_TYPE, &type);
> > +       if (ret < 0)
> > +               return;
> > +
> > +       if (type != PMIC_TYPE_VALUE)
> > +               return;
> > +
> > +       ret = regmap_read(map, PMIC_SUBTYPE, &subtype);
> > +       if (ret < 0)
> > +               return;
> > +
> > +       if (subtype > ARRAY_SIZE(pmic_spmi_id_table))
> > +               return;
> > +
> > +       rev2 = regmap_read(map, PMIC_REV2, &rev2);
> 
> ret = ?

Ouch. will fix.

> 
> > 
> > +
> > +       dev_info(dev, "%s-v%d.%d detected\n",
> > +                       pmic_spmi_id_table[subtype].compatible, major, minor);
> > +}
> > 
> 
> I wonder if this should be dev_dbg.

It is not so much verbose, right? I could cut "detected". I will like to keep it.

Thanks, 
Ivan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/