linux-kernel - Re: [PATCH] sched/deadline: don't need to check throttled status when switched to dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54F820B5.7030503@arm.com>
Date:	Thu, 05 Mar 2015 09:24:05 +0000
From:	Juri Lelli <juri.lelli@....com>
To:	Wanpeng Li <wanpeng.li@...ux.intel.com>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched/deadline: don't need to check throttled status
 when switched to dl

On 05/03/15 01:38, Wanpeng Li wrote:
> Ping Juri,

Yeah, I looked at it this morning. Looks good, thanks!

> On Thu, Feb 26, 2015 at 12:11:04PM +0800, Wanpeng Li wrote:
>> After commit 40767b0dc768 ("sched/deadline: Fix deadline parameter 
>> modification handling"), deadline task throttled status is cleared
>> each time switch from dl, so throttled status always unset when 
>> switch back, there is no need to check throttled status, this patch 
>> drop the check.
>>
>> Signed-off-by: Wanpeng Li <wanpeng.li@...ux.intel.com>

Acked-by: Juri Lelli <juri.lelli@....com>

>> ---
>> kernel/sched/deadline.c | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
>> index ca391c0..cfb8fa7 100644
>> --- a/kernel/sched/deadline.c
>> +++ b/kernel/sched/deadline.c
>> @@ -1697,14 +1697,6 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p)
>> {
>> 	int check_resched = 1;
>>
>> -	/*
>> -	 * If p is throttled, don't consider the possibility
>> -	 * of preempting rq->curr, the check will be done right
>> -	 * after its runtime will get replenished.
>> -	 */
>> -	if (unlikely(p->dl.dl_throttled))
>> -		return;
>> -
>> 	if (task_on_rq_queued(p) && rq->curr != p) {
>> #ifdef CONFIG_SMP
>> 		if (p->nr_cpus_allowed > 1 && rq->dl.overloaded &&
>> -- 
>> 1.9.1
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/