linux-kernel - Re: [PATCH v3] x86: move cacheinfo sysfs to generic cacheinfo infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54F821D8.4030605@arm.com>
Date:	Thu, 05 Mar 2015 09:28:56 +0000
From:	Sudeep Holla <sudeep.holla@....com>
To:	Borislav Petkov <bp@...e.de>
CC:	Sudeep Holla <sudeep.holla@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andre Przywara <Andre.Przywara@....com>,
	"x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH v3] x86: move cacheinfo sysfs to generic cacheinfo infrastructure

Hi Boris,

On 05/03/15 08:16, Borislav Petkov wrote:
> On Wed, Mar 04, 2015 at 01:27:20PM +0100, Borislav Petkov wrote:
>> Applied, thanks guys.
>
> Ok, we forgot to add the same check in the cpu_has_topoext case in
> __cache_amd_cpumap_setup() and my F15h exploded this morning:
>
> ---
> diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c
> index 54e43d58e714..8008bc2dd2d0 100644
> --- a/arch/x86/kernel/cpu/intel_cacheinfo.c
> +++ b/arch/x86/kernel/cpu/intel_cacheinfo.c
> @@ -820,9 +820,13 @@ static int __cache_amd_cpumap_setup(unsigned int cpu, int index,
>
>   		for_each_online_cpu(i) {
>   			this_cpu_ci = get_cpu_cacheinfo(i);
> +			if (!this_cpu_ci->info_list)
> +				continue;
> +
>   			apicid = cpu_data(i).apicid;
>   			if ((apicid < first) || (apicid > last))
>   				continue;
> +
>   			this_leaf = this_cpu_ci->info_list + index;
>
>   			for_each_online_cpu(sibling) {
> ---
>
> I've folded the above into your patch.
>

Thanks a lot.

--
Regards,
Sudeep

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/