linux-kernel - Re: [PATCH v8 2/2] drivers/gpio: Altera soft IP GPIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZPDHwmJaoSBV01wjXC63W90Qk3om8vqkN8RV7E-4hhhQ@mail.gmail.com>
Date:	Thu, 5 Mar 2015 10:37:19 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Tien Hock Loh <thloh@...era.com>
Cc:	Tien Hock Loh <thloh.linux@...il.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Joe Perches <joe@...ches.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Antti Palosaari <crope@....fi>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Dinh Nguyen <dinguyen@...era.com>
Subject: Re: [PATCH v8 2/2] drivers/gpio: Altera soft IP GPIO driver

On Wed, Feb 11, 2015 at 9:20 AM, Tien Hock Loh <thloh@...era.com> wrote:

>> > These calls seem like pretty vanilla generic GPIO functions.
>> > Use GENERIC_GPIO with bgpio_init() and override the default
>> > functions only when really needed.
>> >
>> > See e.g. drivers/gpio/gpio-74xx-mmio.c
>> >
>> OK, I'll update this.
>
> I just recall that I couldn't use bgpio because the number of gpio pins
> is configurable and may not be multiple of 8, thus I'll not be updating
> this to use bgpio.

It doesn't matter. ngpio will be respected by gpio_request() so you
will not be able to request any of the GPIOs above the lower bits
anyway.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/