linux-kernel - Re: [PATCH] Staging: rtl8192e: remove assignment of function parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150305100049.GA6292@sudip-PC>
Date:	Thu, 5 Mar 2015 15:30:49 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Matteo Semenzato <mattew8898@...il.com>
Cc:	gregkh@...uxfoundation.org, mahati.chamarthy@...il.com,
	jjin082693@...il.com, peter.senna@...il.com, quozl@...top.org,
	standby24x7@...il.com, emilgoode@...il.com, mdcasey@...bloom.com,
	rickard_strandqvist@...ctrumdigital.se, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8192e: remove assignment of function
 parameter

On Wed, Mar 04, 2015 at 07:53:10PM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato <mattew8898@...il.com>
> 
> This patch removes the assignment of a function parameter that has no
> effect.
then by the same logic you can also remove another rxb = NULL in rtllib_rx_InfraAdhoc() function..

regards
sudip
> 
> Signed-off-by: Matteo Semenzato <mattew8898@...il.com>
> ---
>  drivers/staging/rtl8192e/rtllib_rx.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index 1664040..c35a5da 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -1226,7 +1226,6 @@ static void rtllib_rx_indicate_pkt_legacy(struct rtllib_device *ieee,
>  		}
>  	}
>  	kfree(rxb);
> -	rxb = NULL;
>  }
>  
>  static int rtllib_rx_InfraAdhoc(struct rtllib_device *ieee, struct sk_buff *skb,
> -- 
> 2.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/