linux-kernel - Re: [PATCH] Remove deprecated IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD3Xx4L3QWW91NupRevugvixNxoE8bk5Hf5XrgG-NYcPu9S=Sg@mail.gmail.com>
Date:	Thu, 5 Mar 2015 14:33:13 +0100
From:	Valentin Rothberg <valentinrothberg@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	akpm@...ux-foundation.org, Jonathan Corbet <corbet@....net>,
	Ralf Baechle <ralf@...ux-mips.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Paul Bolle <pebolle@...cali.nl>, Jiri Kosina <jkosina@...e.cz>,
	Ewan Milne <emilne@...hat.com>, Hannes Reinecke <hare@...e.de>,
	Christoph Hellwig <hch@....de>,
	Huacai Chen <chenhc@...ote.com>,
	Hongliang Tao <taohl@...ote.com>, Nishanth Menon <nm@...com>,
	Santosh Shilimkar <santosh.shilimkar@...com>,
	Peter Ujfalusi <peter.ujfalusi@...com>,
	Tony Lindgren <tony@...mide.com>,
	Rajendra Nayak <rnayak@...com>,
	Sricharan R <r.sricharan@...com>,
	Afzal Mohammed <afzal@...com>, Keerthy <j-keerthy@...com>,
	Zhou Wang <wangzhou1@...ilicon.com>,
	Felipe Balbi <balbi@...com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Randy Dunlap <rdunlap@...radead.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Quentin Lambert <lambert.quentin@...il.com>,
	Eyal Perry <eyalpe@...lanox.com>,
	Arnd Bergmann <arnd@...db.de>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-mips@...ux-mips.org, iss_storagedev@...com,
	linux-mtd@...ts.infradead.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] Remove deprecated IRQF_DISABLED flag entirely

On Thu, Mar 5, 2015 at 2:08 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> On Thu, Mar 05, 2015 at 01:59:39PM +0100, Valentin Rothberg wrote:
>> diff --git a/drivers/mtd/nand/hisi504_nand.c b/drivers/mtd/nand/hisi504_nand.c
>> index 289ad3ac3e80..7f9f9c827c1d 100644
>> --- a/drivers/mtd/nand/hisi504_nand.c
>> +++ b/drivers/mtd/nand/hisi504_nand.c
>> @@ -758,8 +758,7 @@ static int hisi_nfc_probe(struct platform_device *pdev)
>>
>>       hisi_nfc_host_init(host);
>>
>> -     ret = devm_request_irq(dev, irq, hinfc_irq_handle, IRQF_DISABLED,
>> -                             "nandc", host);
>> +     ret = devm_request_irq(dev, irq, hinfc_irq_handle, "nandc", host);
>
> I think this breaks the build.

You're completely right, thanks!  Obviously I missed compiling this
driver.  I will fix it.

Kind regards,
 Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/