linux-kernel - Re: [PATCH v5 6/8] pinctrl: cygnus: add gpio/pinconf driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Mar 2015 09:13:28 -0800
From:	Ray Jui <rjui@...adcom.com>
To:	Paul Bolle <pebolle@...cali.nl>
CC:	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"Kumar Gala" <galak@...eaurora.org>,
	Grant Likely <grant.likely@...aro.org>,
	Christian Daudt <bcm@...thebug.org>,
	Matt Porter <mporter@...aro.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	Scott Branden <sbranden@...adcom.com>,
	Dmitry Torokhov <dtor@...gle.com>,
	Anatol Pomazau <anatol@...gle.com>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-gpio@...r.kernel.org>,
	<bcm-kernel-feedback-list@...adcom.com>,
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v5 6/8] pinctrl: cygnus: add gpio/pinconf driver

Hi Paul,

On 3/5/2015 12:36 AM, Paul Bolle wrote:
> On Thu, 2015-03-05 at 09:11 +0100, Paul Bolle wrote:
>> On Wed, 2015-03-04 at 16:35 -0800, Ray Jui wrote:
>>> +MODULE_AUTHOR("Ray Jui <rjui@...adcom.com>");
>>> +MODULE_DESCRIPTION("Broadcom Cygnus GPIO Driver");
>>> +MODULE_LICENSE("GPL v2");
>>
>> These three macros will be preprocessed away. (There's also
>> MODULE_DEVICE_TABLE. I don't yet know how that is handled in a
>> non-modular build, sorry.)
> 
> It turns out MODULE_DEVICE_TABLE is _really_ preprocessed away. See
> include/linux/module.h:
>     #ifdef MODULE
>     /* Creates an alias so file2alias.c can find device table. */
>     #define MODULE_DEVICE_TABLE(type, name)                                 \
>     extern const typeof(name) __mod_##type##__##name##_device_table         \
>       __attribute__ ((unused, alias(__stringify(name))))
>     #else  /* !MODULE */
>     #define MODULE_DEVICE_TABLE(type, name)
>     #endif
> 
> 
> Did I get that right?
> 
> (I knew the other three MODULE_* macros are handled in slightly more
> complicated way, but the effect is basically that they are preprocessed
> away.)
> 
> 
> Paul Bolle
> 

Even these module macros will be pre-processed away when the driver is
statically linked (and yes, I'm not planning to ever make these driver
built as module), I'm not too sure about the convention here. I thought
that they are still good to be in the driver for information purpose.
I'm seeing other pinctrl drivers doing this as well.

Maybe Linus can help to clarify this?

Thanks,

Ray
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/