linux-kernel - Re: [PATCH v1][CLEANUP] x86: use already defined macros instead of hard-coded values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Mar 2015 00:12:09 +0600
From:	Alexander Kuleshov <kuleshovmail@...il.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1][CLEANUP] x86: use already defined macros instead of
 hard-coded values

Hello Borislav,

>
> This patch introduces two new bugs. For educational purposes I'm not
> going to tell you where they are but let you find them.
>

Ok, i looked on it with gdb, and X86_FEATURE_NX is not correct here.
It's a bug number one.
And L3_START_KERNEL*8 + 1, must be L3_START_KERNEL*8 + 8, as we works
with page entries
or i'm wrong here?

Anyway, thanks for education:)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/