linux-kernel - x32 + audit status?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHse=S8=2TZQVni3ervR1ai7gd0K6RFTU6D67CfLrpxn-h1-Vg@mail.gmail.com>
Date:	Thu, 5 Mar 2015 18:32:00 +0000
From:	David Drysdale <drysdale@...gle.com>
To:	Paul Moore <paul@...l-moore.com>, Eric Paris <eparis@...hat.com>
Cc:	Kees Cook <keescook@...omium.org>,
	Andy Lutomirski <luto@...capital.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-audit@...hat.com
Subject: x32 + audit status?

Hi,

Do we currently expect the audit system to work with x32 syscalls?

I was playing with the audit system for the first time today (on
v4.0-rc2, due to [1]), and it didn't seem to work for me.  (Tweaking
ptrace.c like the patch below seemed to help, but I may just have
configured something wrong.)

I know there was a bunch of activity around this area in mid-2014,
but I'm not sure what the final position was...

Thanks,
David

[1]: https://lkml.org/lkml/2015/3/4/879

diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
index e510618b2e91..443932afd9e8 100644
--- a/arch/x86/kernel/ptrace.c
+++ b/arch/x86/kernel/ptrace.c
@@ -1445,7 +1445,7 @@ static void do_audit_syscall_entry(struct
pt_regs *regs, u32 arch)
 {
 #ifdef CONFIG_X86_64
        if (arch == AUDIT_ARCH_X86_64) {
-               audit_syscall_entry(regs->orig_ax, regs->di,
+               audit_syscall_entry(regs->orig_ax & __SYSCALL_MASK, regs->di,
                                    regs->si, regs->dx, regs->r10);
        } else
 #endif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/