linux-kernel - Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on "I2C=y" and "I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqLerNgRsmHPCedtfNSO9fZj=cBpe8PF4uZPkVF-Urcxaw@mail.gmail.com>
Date:	Thu, 5 Mar 2015 14:01:31 -0600
From:	Rob Herring <robherring2@...il.com>
To:	Pantelis Antoniou <pantelis.antoniou@...sulko.com>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Chen Gang <xili_gchen_5257@...mail.com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on "I2C=y" and "I2C_MUX=y"

On Wed, Mar 4, 2015 at 1:58 PM, Pantelis Antoniou
<pantelis.antoniou@...sulko.com> wrote:
> Hi Arnd,
>
>> On Mar 4, 2015, at 21:49 , Arnd Bergmann <arnd@...db.de> wrote:
>>
>> On Wednesday 04 March 2015 16:04:23 Geert Uytterhoeven wrote:
>>>> -       depends on OF_IRQ && OF_EARLY_FLATTREE
>>>> +       depends on OF_IRQ && OF_EARLY_FLATTREE && I2C=y && I2C_MUX=y
>>>
>>> ... I think it would be better to replace "#if IS_ENABLED(CONFIG_XXX)" by
>>> "#ifdef CONFIG_XXX" in drivers/of/unittest.c instead.
>>>
>>
>> Agreed. I came across the same bug and came to the same conclusion as you.
>>
>> How about this:
>>
>> 8<----
>> Subject: of: unittest: fix I2C dependency

[...]

>> -#if IS_ENABLED(CONFIG_I2C)
>> +#if IS_BUILTIN(CONFIG_I2C)
>>       if (selftest(of_selftest_overlay_i2c_init() == 0, "i2c init failed\n"))
>>               goto out;
>>
>>
>
> Patch is fine. I’ll pick it up for the next batch of overlay patches.

Do you have other things that need to go into 4.0? If not I'll pick this up.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/