linux-kernel - Re: [PATCH] checkpatch: Add spell checking of email subject line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ioeetvbi.fsf@intel.com>
Date:	Fri, 06 Mar 2015 09:54:25 +0200
From:	Jani Nikula <jani.nikula@...ux.intel.com>
To:	Joe Perches <joe@...ches.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Ville Syrjälä <ville.syrjala@...ux.intel.com>,
	"Purushothaman\, Vijay A" <vijay.a.purushothaman@...ux.intel.com>,
	Andy Whitcroft <apw@...onical.com>,
	LKML <linux-kernel@...r.kernel.org>,
	intel-gfx@...ts.freedesktop.org
Subject: Re: [PATCH] checkpatch: Add spell checking of email subject line

On Thu, 05 Mar 2015, Joe Perches <joe@...ches.com> wrote:
> Only commit log and patch additions are checked for
> typos and spelling errors currently.  Add a check
> of the email subject line too.
>
> Suggested-by: Jani Nikula <jani.nikula@...ux.intel.com>
> Signed-off-by: Joe Perches <joe@...ches.com>

Thanks Joe.

FWIW,

Tested-by: Jani Nikula <jani.nikula@...el.com>

> ---
>  scripts/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 421bbb4..c061a63 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2303,7 +2303,8 @@ sub process {
>  		}
>  
>  # Check for various typo / spelling mistakes
> -		if (defined($misspellings) && ($in_commit_log || $line =~ /^\+/)) {
> +		if (defined($misspellings) &&
> +		    ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) {
>  			while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:$|[^a-z@])/gi) {
>  				my $typo = $1;
>  				my $typo_fix = $spelling_fix{lc($typo)};
>
>

-- 
Jani Nikula, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/