linux-kernel - Re: [PATCH 0/17] crypto: talitos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54F967D0.5030209@c-s.fr>
Date:	Fri, 06 Mar 2015 09:39:44 +0100
From:	leroy christophe <christophe.leroy@....fr>
To:	Herbert Xu <herbert@...dor.apana.org.au>,
	Kim Phillips <kim.phillips@...escale.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	linux-crypto@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 0/17] crypto: talitos - Add support for SEC1

Le 06/03/2015 01:28, Herbert Xu a écrit :
> On Thu, Mar 05, 2015 at 06:21:01PM -0600, Kim Phillips wrote:
>> On Thu, 5 Mar 2015 17:46:05 +0100
>> Christophe Leroy <christophe.leroy@....fr> wrote:
>>
>>> [15/17] crypto: talitos - Implementation of SEC1
>> ...
>>
>>> [16/17] crypto: talitos - SEC1 bugs on 0 data hash
>>> [17/17] crypto: talitos - Update DT bindings with SEC1
>> This patchseries doesn't apply, at least on top of Herbert's
>> cryptodev-2.6 tree, as of today:
>>
>> Applying: crypto: talitos - Implementation of SEC1
>> error: patch failed: drivers/crypto/talitos.c:655
>> error: drivers/crypto/talitos.c: patch does not apply
> Also the patches are coming in a random order.  Please send them
> one at a time to ensure proper ordering.
>
> Thanks,
Kim, I have now tried on top of cryptodev-2.6 tree, and for me it works 
(see below).
Do I clone cryptodev-2.6 from the wrong place ?
On that clone, the latest commit on talitos.c is commit 
5be4d4c94b1f98b839344fda7a8752a4a09d0ef5 "crypto: replace 
scatterwalk_sg_next with sg_next"

[root@...alhost ~]# git clone 
https://www.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
Cloning into 'cryptodev-2.6'...
remote: Counting objects: 4043448, done.
remote: Compressing objects: 100% (682829/682829), done.
Receiving objects: 100% (4043448/4043448), 893.52 MiB | 258.00 KiB/s, done.
remote: Total 4043448 (delta 3330215), reused 4043104 (delta 3329977)
Resolving deltas: 100% (3330215/3330215), done.
Checking connectivity... done.
Checking out files: 100% (48971/48971), done.
[root@...alhost ~]# cd cryptodev-2.6/
[root@...alhost cryptodev-2.6]# git branch test
[root@...alhost cryptodev-2.6]# git checkout test
Switched to branch 'test'
[root@...alhost cryptodev-2.6]# git am 
/root/gen/trunk/submitted_patches/talitos/0*
Applying: crypto: talitos - base address for Execution Units and macro 
for ISR masks
Applying: crypto: talitos - Externalise specific SEC2 reset actions
Applying: crypto: talitos - Use zero entry to init descriptors ptrs to zero
Applying: crypto: talitos - Refactor the sg in/out chain allocation
Applying: crypto: talitos - isolate scatter/gather handling for ahash
Applying: crypto: talitos - Add talitos2.c to isolate SEC2 specific 
functions
Applying: crypto: talitos - Split talitos.h into 2 parts
Applying: crypto: talitos - Deport SEC2 error handling
Applying: crypto: talitos - Move reset/init helpers into talitos2.h
Applying: crypto: talitos - Move interrupt related macros in talitos2.h
Applying: crypto: talitos - Move hash chain handling into talitos2.h
Applying: crypto: talitos - Define compatible in talitos2.h instead of 
talitos.c
Applying: crypto: talitos - move sg_count() helper into talitos.h
Applying: crypto: talitos - Add a helper function to clear j_extent field
Applying: crypto: talitos - Implementation of SEC1
Applying: crypto: talitos - SEC1 bugs on 0 data hash
Applying: crypto: talitos - Update DT bindings with SEC1
[root@...alhost cryptodev-2.6]#

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/