linux-kernel - Re: [PATCH 2/2 v2] kernel: irq: rename irq_set_default_host to irq_domain_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbY=qyRSWYEhzYj8cg=jevz92YaCPStrN38jdoLXit0SQ@mail.gmail.com>
Date:	Fri, 6 Mar 2015 11:20:18 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 2/2 v2] kernel: irq: rename irq_set_default_host to irq_domain_set_default()

On Mon, Feb 16, 2015 at 1:09 PM, Benjamin Herrenschmidt
<benh@...nel.crashing.org> wrote:
> On Mon, 2015-02-16 at 10:53 +0100, Peter Zijlstra wrote:
>> On Fri, Feb 13, 2015 at 08:02:17AM +0800, Linus Walleij wrote:
>> > This function does not conform to the irq_domain* namespace and
>> > makes it a disturbing artifact dating back to a time when irq
>> > domains were referred to as "hosts". Rename it.
>
> My little coat of paint on that shed...
>
> While I agree with the need to rename it, do we really need to adhere to
> strict namespaces like that ? It would be a lot nicer to call it
> irq_set_default_domain() :-)

Since all other functions in <linux/irqdomain.h> begin with the
irq_domain* prefix that seriously disturbs my OCD ... ;)

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/