linux-kernel - Re: [PATCH] spi: fsl-spi: use of_iomap() to map parameter ram on CPM1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150306114413.GM21293@sirena.org.uk>
Date:	Fri, 6 Mar 2015 11:44:13 +0000
From:	Mark Brown <broonie@...nel.org>
To:	leroy christophe <christophe.leroy@....fr>
Cc:	linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	linux-spi@...r.kernel.org
Subject: Re: [PATCH] spi: fsl-spi: use of_iomap() to map parameter ram on CPM1

On Wed, Mar 04, 2015 at 09:00:39AM +0100, leroy christophe wrote:
> Le 03/03/2015 19:44, Mark Brown a écrit :

> >Why are we using of_iomap() rather than a generic I/O mapping function
> >here?

> because all drivers for powerpc seems to be using of_iomap(), as on powerpc
> the HW is described by the bootloader in a OF device tree.
> Today, of_iomap() is at least used in FSL SPI, FSL UART, SPI mpc52xx, UART
> mpc52xx, i2c-mpc, i2c-cpm, freescale ethernet drivers, etc ....

> Is it not correct ?

It's legacy, all that code is really old.  Modern code is written in as
architecture and firmware neutral a fashion as possible to make things
more consistent and maintainable.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)