linux-kernel - Re: [PATCH 2/2] net: macb: Fix multi queue support for xilinx ZynqMP soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 6 Mar 2015 17:55:23 +0100
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Michal Simek <michal.simek@...inx.com>,
	<linux-kernel@...r.kernel.org>, <monstr@...str.eu>
CC:	Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@...inx.com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH 2/2] net: macb: Fix multi queue support for xilinx ZynqMP
 soc

Le 05/03/2015 14:04, Michal Simek a écrit :
> From: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@...inx.com>
> 
> ZynqMP soc has single interrupt for all the queue events. So,
> passing the IRQF_SHARED flag for interrupt registration call.
> 
> Signed-off-by: Punnaiah Choudary Kalluri <punnaia@...inx.com>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>

Ok then:
Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

> ---
> 
>  drivers/net/ethernet/cadence/macb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 24b1eb466e52..0493c3e6bbbe 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -2319,7 +2319,7 @@ static int macb_probe(struct platform_device *pdev)
>  		 */
>  		queue->irq = platform_get_irq(pdev, q);
>  		err = devm_request_irq(&pdev->dev, queue->irq, macb_interrupt,
> -				       0, dev->name, queue);
> +				       IRQF_SHARED, dev->name, queue);
>  		if (err) {
>  			dev_err(&pdev->dev,
>  				"Unable to request IRQ %d (error %d)\n",
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/