linux-kernel - Re: [PATCH v2] Remove deprecated IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150306184605.GQ18140@ld-irv-0074>
Date:	Fri, 6 Mar 2015 10:46:05 -0800
From:	Brian Norris <computersforpeace@...il.com>
To:	Valentin Rothberg <valentinrothberg@...il.com>
Cc:	akpm@...ux-foundation.org, Jonathan Corbet <corbet@....net>,
	Ralf Baechle <ralf@...ux-mips.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Paul Bolle <pebolle@...cali.nl>, Jiri Kosina <jkosina@...e.cz>,
	Hannes Reinecke <hare@...e.de>, Ewan Milne <emilne@...hat.com>,
	Christoph Hellwig <hch@....de>,
	Hongliang Tao <taohl@...ote.com>,
	Huacai Chen <chenhc@...ote.com>, Nishanth Menon <nm@...com>,
	Peter Ujfalusi <peter.ujfalusi@...com>,
	Santosh Shilimkar <santosh.shilimkar@...com>,
	Tony Lindgren <tony@...mide.com>,
	Rajendra Nayak <rnayak@...com>, Afzal Mohammed <afzal@...com>,
	Keerthy <j-keerthy@...com>, Sricharan R <r.sricharan@...com>,
	Zhou Wang <wangzhou1@...ilicon.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Felipe Balbi <balbi@...com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Quentin Lambert <lambert.quentin@...il.com>,
	Arnd Bergmann <arnd@...db.de>, Ingo Molnar <mingo@...nel.org>,
	Eyal Perry <eyalpe@...lanox.com>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-mips@...ux-mips.org, iss_storagedev@...com,
	linux-mtd@...ts.infradead.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v2] Remove deprecated IRQF_DISABLED flag entirely

On Thu, Mar 05, 2015 at 03:23:08PM +0100, Valentin Rothberg wrote:
> The IRQF_DISABLED is a NOOP and has been scheduled for removal since
> Linux v2.6.36 by commit 6932bf37bed4 ("genirq: Remove IRQF_DISABLED from
> core code").
> 
> According to commit e58aa3d2d0cc ("genirq: Run irq handlers with
> interrupts disabled") running IRQ handlers with interrupts enabled can
> cause stack overflows when the interrupt line of the issuing device is
> still active.
> 
> This patch ends the grace period for IRQF_DISABLED (i.e., SA_INTERRUPT
> in older versions of Linux) and removes the definition and all remaining
> usages of this flag.
> 
> Signed-off-by: Valentin Rothberg <valentinrothberg@...il.com>
> ---
> The bigger hunk in Documentation/scsi/ncr53c8xx.txt is removed entirely
> as IRQF_DISABLED is gone now; the usage in older kernel versions
> (including the old SA_INTERRUPT flag) should be discouraged.  The
> trouble of using IRQF_SHARED is a general problem and not specific to
> any driver.
> 
> I left the reference in Documentation/PCI/MSI-HOWTO.txt untouched since
> it has already been removed in linux-next by commit b0e1ee8e1405
> ("MSI-HOWTO.txt: remove reference on IRQF_DISABLED").
> 
> All remaining references are changelogs that I suggest to keep.
> 
> Changelog
> 
> v2: Correct previous change to drivers/mtd/nand/hisi504_nand.c that
> broke compilation.  Reported by Dan Carpenter.
> ---
>  Documentation/scsi/ncr53c8xx.txt     | 25 -------------------------
>  Documentation/scsi/tmscsim.txt       |  4 ----
>  arch/mips/loongson/loongson-3/hpet.c |  2 +-
>  drivers/block/cpqarray.c             |  4 ++--
>  drivers/bus/omap_l3_noc.c            |  4 ++--
>  drivers/bus/omap_l3_smx.c            | 10 ++++------
>  drivers/mtd/nand/hisi504_nand.c      |  3 +--
>  drivers/usb/isp1760/isp1760-core.c   |  3 +--
>  drivers/usb/isp1760/isp1760-udc.c    |  4 ++--
>  include/linux/interrupt.h            |  3 ---
>  10 files changed, 13 insertions(+), 49 deletions(-)
> 

For this piece:

> diff --git a/drivers/mtd/nand/hisi504_nand.c b/drivers/mtd/nand/hisi504_nand.c
> index 289ad3ac3e80..8dcc7b8fee40 100644
> --- a/drivers/mtd/nand/hisi504_nand.c
> +++ b/drivers/mtd/nand/hisi504_nand.c
> @@ -758,8 +758,7 @@ static int hisi_nfc_probe(struct platform_device *pdev)
>  
>  	hisi_nfc_host_init(host);
>  
> -	ret = devm_request_irq(dev, irq, hinfc_irq_handle, IRQF_DISABLED,
> -				"nandc", host);
> +	ret = devm_request_irq(dev, irq, hinfc_irq_handle, 0x0, "nandc", host);
>  	if (ret) {
>  		dev_err(dev, "failed to request IRQ\n");
>  		goto err_res;

Acked-by: Brian Norris <computersforpeace@...il.com>

Sorry for the oversight in review, and thanks for the fixup.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/