linux-kernel - Re: [PATCH 00/10] omap3 crypto fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Mar 2015 11:18:45 -0800
From:	Tony Lindgren <tony@...mide.com>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Benoît Cousson <bcousson@...libre.com>,
	Rob Herring <robh+dt@...nel.org>,
	Russell King <linux@....linux.org.uk>,
	Paul Walmsley <paul@...an.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	Pavel Machek <pavel@....cz>, Nishanth Menon <nm@...com>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Sebastian Reichel <sre@...nel.org>
Subject: Re: [PATCH 00/10] omap3 crypto fixes

* Pali Rohár <pali.rohar@...il.com> [150306 11:16]:
> On Friday 06 March 2015 19:36:32 Tony Lindgren wrote:
> > * Pali Rohár <pali.rohar@...il.com> [150226 05:54]:
> > > This patch series fix crypto support for omap3 devices which
> > > use DT.
> > > 
> > > It enables AES and SHAM on N9/N950 and SHAM on N900. AES is
> > > still disabled for N900.
> > > 
> > > Pali Rohár (10):
> > >   ARM: OMAP2+: Return correct error values from device and
> > >   hwmod ARM: OMAP3: Fix crypto support for HS devices
> > >   crypto: omap-sham: Add support for omap3 devices
> > >   crypto: omap-sham: Check for return value from
> > >   pm_runtime_get_sync ARM: dts: omap3 hs: Remove timer12
> > >   ARM: dts: omap3: Add missing dmas for crypto
> > >   ARM: dts: n9/n950: Enable omap crypto support
> > >   ARM: dts: n900: Enable omap sham and include directly
> > >   omap34xx.dtsi ARM: dts: omap3-tao3530: Include directly
> > >   omap34xx.dtsi ARM: dts: Remove files omap34xx-hs.dtsi and
> > >   omap36xx-hs.dtsi
> > >  
> > >  arch/arm/boot/dts/omap3-n900.dts           |   16 +++++-
> > >  arch/arm/boot/dts/omap3-n950-n9.dtsi       |    2 +-
> > >  arch/arm/boot/dts/omap3-tao3530.dtsi       |   11 +++-
> > >  arch/arm/boot/dts/omap3.dtsi               |    4 ++
> > >  arch/arm/boot/dts/omap34xx-hs.dtsi         |   16 ------
> > >  arch/arm/boot/dts/omap36xx-hs.dtsi         |   16 ------
> > >  arch/arm/mach-omap2/omap_device.c          |   30
> > >  ++++++----- arch/arm/mach-omap2/omap_hwmod.c           |  
> > >  10 ++-- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |   79
> > >  +++++++++++++++++++++++----- drivers/crypto/omap-sham.c   
> > >               |   13 ++++- 10 files changed, 131
> > >  insertions(+), 66 deletions(-) delete mode 100644
> > >  arch/arm/boot/dts/omap34xx-hs.dtsi delete mode 100644
> > >  arch/arm/boot/dts/omap36xx-hs.dtsi
> > 
> > Are there any fixes in this series that should go into
> > v4.0-rc series, or can it all wait for v4.1?
> > 
> > Regards,
> > 
> > Tony
> 
> I do not know which patches are you sending to 4.0-rc series, but 
> omap crypto is totally broken in linus tree for both GP & HS 
> omap3 devices when DT booting is used. This patch series fix that 
> problem.

OK so the whole series is needed then. It seems too intrusive for
the v4.0-rc series unless this fixes a regression with some earlier
commit.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/