linux-kernel - Re: [PATCH stable 3.10, 3.12, 3.14] MIPS: Export FP functions used by lose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150306204204.GA25430@roeck-us.net>
Date:	Fri, 6 Mar 2015 12:42:04 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	James Hogan <james.hogan@...tec.com>, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	satoru.takeuchi@...il.com, shuah.kh@...sung.com,
	stable@...r.kernel.org, linux-mips@...ux-mips.org,
	Paolo Bonzini <pbonzini@...hat.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Paul Burton <paul.burton@...tec.com>,
	Gleb Natapov <gleb@...nel.org>, kvm@...r.kernel.org
Subject: Re: [PATCH stable 3.10, 3.12, 3.14] MIPS: Export FP functions used
 by lose_fpu(1) for KVM

On Fri, Mar 06, 2015 at 09:45:16AM -0800, Greg Kroah-Hartman wrote:
> On Fri, Mar 06, 2015 at 08:22:49AM -0800, Guenter Roeck wrote:
> > On Thu, Mar 05, 2015 at 10:30:34PM -0800, Greg Kroah-Hartman wrote:
> > > On Thu, Mar 05, 2015 at 04:08:44PM +0000, James Hogan wrote:
> > > > [ Upstream commit 3ce465e04bfd8de9956d515d6e9587faac3375dc ]
> > > > 
> > > > Export the _save_fp asm function used by the lose_fpu(1) macro to GPL
> > > > modules so that KVM can make use of it when it is built as a module.
> > > > 
> > > > This fixes the following build error when CONFIG_KVM=m due to commit
> > > > f798217dfd03 ("KVM: MIPS: Don't leak FPU/DSP to guest"):
> > > > 
> > > > ERROR: "_save_fp" [arch/mips/kvm/kvm.ko] undefined!
> > > > 
> > > > Signed-off-by: James Hogan <james.hogan@...tec.com>
> > > > Fixes: f798217dfd03 (KVM: MIPS: Don't leak FPU/DSP to guest)
> > > > Cc: Paolo Bonzini <pbonzini@...hat.com>
> > > > Cc: Ralf Baechle <ralf@...ux-mips.org>
> > > > Cc: Paul Burton <paul.burton@...tec.com>
> > > > Cc: Gleb Natapov <gleb@...nel.org>
> > > > Cc: kvm@...r.kernel.org
> > > > Cc: linux-mips@...ux-mips.org
> > > > Cc: <stable@...r.kernel.org> # 3.10...3.15
> > > > Patchwork: https://patchwork.linux-mips.org/patch/9260/
> > > > Signed-off-by: Ralf Baechle <ralf@...ux-mips.org>
> > > > [james.hogan@...tec.com: Only export when CPU_R4K_FPU=y prior to v3.16,
> > > >  so as not to break the Octeon build which excludes FPU support. KVM
> > > >  depends on MIPS32r2 anyway.]
> > > > Signed-off-by: James Hogan <james.hogan@...tec.com>
> > > > ---
> > > > Appologies for the previous cavium_octeon_defconfig link breakage.
> > > > Octeon has the symbol since 3.16, but not before. This backport should
> > > > do the trick for stable 3.10, 3.12, and 3.14. Build tested with
> > > > cavium_octeon_defconfig and malta_kvm_defconfig on those stable
> > > > branches.
> > > > ---
> > > >  arch/mips/kernel/mips_ksyms.c | 8 ++++++++
> > > >  1 file changed, 8 insertions(+)
> > > 
> > > Now fixed up, thanks.
> > > 
> > My auto-builders still fail to build cavium_octeon_defconfig for 3.10 and 3.14,
> > and as far as I can see they picked up no changes. Did you push the changes into
> > the stable queue repository ?
> 
> I didn't push it publically, didn't have access to my 2-factor key so
> couldn't do it.  Should be there now, sorry about that.
> 
Confirmed, all is good now.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/