linux-kernel - Re: twl4030_charger: need changes to get probed?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150306224034.GA20559@amd>
Date:	Fri, 6 Mar 2015 23:40:34 +0100
From:	Pavel Machek <pavel@....cz>
To:	Grazvydas Ignotas <notasas@...il.com>
Cc:	Pali Rohár <pali.rohar@...il.com>,
	ivo.g.dimitrov.75@...il.com, Samuel Ortiz <sameo@...ux.intel.com>,
	khilman@...nel.org, NeilBrown <neilb@...e.de>, sre@...ian.org,
	linux-pm@...r.kernel.org, Aaro Koskinen <aaro.koskinen@....fi>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	kernel list <linux-kernel@...r.kernel.org>,
	Sebastian Reichel <sre@...nel.org>,
	GTA04 owners <gta04-owner@...delico.com>, sre@...g0.de,
	Tony Lindgren <tony@...mide.com>,
	David Woodhouse <dwmw2@...radead.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	Lee Jones <lee.jones@...aro.org>, patrikbachan@...il.com,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: twl4030_charger: need changes to get probed?

On Sat 2015-03-07 00:12:07, Grazvydas Ignotas wrote:
> On Fri, Mar 6, 2015 at 11:57 PM, Pali Rohár <pali.rohar@...il.com> wrote:
> > On Friday 06 March 2015 22:24:17 Pavel Machek wrote:
> >> Hi!
> >>
> >> According to n900 dts, twl4030-bci (aka charger) should be
> >> included.
> >>
> >
> > AFAIK it is not present on n900...
> 
> Right, it uses twl5030 variant without the charger, charging on n900
> is provided by separate chip and for a good reason as twl's charger is
> not that good. Forcing the driver to load just ends up with it
> accessing non-existent registers over i2c.

Ok, but:

1) Why is the twl4030-bci enabled in n900's dts, then

and

2) When it is enabled, why it does not load?

(I guess there's no way to get to input voltage on n900...?)

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/