linux-kernel - Re: [PATCH] kernel/locking/locktorture: fix deadlock in 'rw_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Mar 2015 16:37:42 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Alexey Kodanev <alexey.kodanev@...cle.com>
Cc:	josh@...htriplett.org, linux-kernel@...r.kernel.org,
	vasily.isaenko@...cle.com, dave@...olabs.net
Subject: Re: [PATCH] kernel/locking/locktorture: fix deadlock in
 'rw_lock_irq' type

On Sat, Mar 07, 2015 at 03:06:53AM +0300, Alexey Kodanev wrote:
> torture_rwlock_read_unlock_irq() must use read_unlock_irqrestore()
> instead of write_unlock_irqrestore().
> 
> Use read_unlock_irqrestore() instead of write_unlock_irqrestore().
> 
> Signed-off-by: Alexey Kodanev <alexey.kodanev@...cle.com>

Good catch!  If Davidlohr has no objections, I will queue this one.

							Thanx, Paul

> ---
>  kernel/locking/locktorture.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
> index ec8cce2..6a2723c 100644
> --- a/kernel/locking/locktorture.c
> +++ b/kernel/locking/locktorture.c
> @@ -309,7 +309,7 @@ static int torture_rwlock_read_lock_irq(void) __acquires(torture_rwlock)
>  static void torture_rwlock_read_unlock_irq(void)
>  __releases(torture_rwlock)
>  {
> -	write_unlock_irqrestore(&torture_rwlock, cxt.cur_ops->flags);
> +	read_unlock_irqrestore(&torture_rwlock, cxt.cur_ops->flags);
>  }
> 
>  static struct lock_torture_ops rw_lock_irq_ops = {
> -- 
> 1.7.1
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/