linux-kernel - Re: [PATCH 10/12] clocksource: Mostly kill clocksource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150307094511.GH30888@gmail.com>
Date:	Sat, 7 Mar 2015 10:45:12 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	John Stultz <john.stultz@...aro.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Dave Jones <davej@...emonkey.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Richard Cochran <richardcochran@...il.com>,
	Prarit Bhargava <prarit@...hat.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Peter Zijlstra <peterz@...radead.org>,
	"David S. Miller" <davem@...emloft.net>,
	Martin Schwidefsky <schwidefsky@...ibm.com>
Subject: Re: [PATCH 10/12] clocksource: Mostly kill clocksource_register()


* John Stultz <john.stultz@...aro.org> wrote:

> A long running project has been to cleanup remaining uses
> of clocksource_register(), replacing it with the simpler
> clocksource_register_khz/hz().

s/.$/ functions.

> However, there are a few cases where we need to self-define
> our mult/shift values, so switch the function to a more
> obviously internal __clocksource_register(), and consolidate

s/(),/() name,

> much of the internal logic so we don't have duplication.

> +	if (freq) {
> +		/*
> +		 * Calc the maximum number of seconds which we can run before
> +		 * wrapping around. For clocksources which have a mask > 32bit
> +		 * we need to limit the max sleep time to have a good
> +		 * conversion precision. 10 minutes is still a reasonable
> +		 * amount. That results in a shift value of 24 for a
> +		 * clocksource with mask >= 40bit and f >= 4GHz. That maps to
> +		 * ~ 0.06ppm granularity for NTP.

s/32bit/32-bit
s/40bit/40-bit

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/