linux-kernel - Re: [PATCH] x86: clean up unnecessarily wide TEST insns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 7 Mar 2015 11:13:36 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Andy Lutomirski <luto@...capital.net>
Cc:	Denys Vlasenko <dvlasenk@...hat.com>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Borislav Petkov <bp@...en8.de>,
	"H. Peter Anvin" <hpa@...or.com>, Oleg Nesterov <oleg@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Will Drewry <wad@...omium.org>,
	Kees Cook <keescook@...omium.org>, X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: clean up unnecessarily wide TEST insns


* Andy Lutomirski <luto@...capital.net> wrote:

> >     +f6 c1 04                   test   $0x4,%cl
> >     -48 f7 c1 08 00 00 00       test   $0x8,%rcx
> >     +f6 c1 08                   test   $0x8,%cl
> >
> >  arch/x86/kernel/head_64.S            |  2 +-
> >  arch/x86/kernel/relocate_kernel_32.S |  8 ++++----
> >  arch/x86/kernel/relocate_kernel_64.S |  8 ++++----
> >  arch/x86/lib/checksum_32.S           |  4 ++--
> >  arch/x86/lib/csum-copy_64.S          |  2 +-
> 
> Looks good to me.  Ingo, should I queue this up?

No need, I picked it up now that the 32-bit crash of tip:x86/asm is 
fixed. I juiced up the changelog a bit. Will push it out after a bit 
of testing.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/