linux-kernel - Re: [PATCH] regmap: introduce regmap_name to fix syscon regmap trace events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150307105747.GC28806@sirena.org.uk>
Date:	Sat, 7 Mar 2015 10:57:47 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	Pankaj Dubey <pankaj.dubey@...sung.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH] regmap: introduce regmap_name to fix syscon regmap trace
 events

On Fri, Mar 06, 2015 at 03:16:55PM +0100, Philipp Zabel wrote:

>  #include <linux/sort.h>
> -#include <trace/events/regmap.h>
>  
>  #include "internal.h"
>  
> +#include <trace/events/regmap.h>
> +

The change is basically OK but the above is a bit too funky for my
taste - it feels like it's asking for annoying compile breakage if
anyone changes anything.  I'd be more inclined to move the header
somewhere where the events stuff can see it than do this.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)