linux-kernel - Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150307105948.GD28806@sirena.org.uk>
Date:	Sat, 7 Mar 2015 10:59:48 +0000
From:	Mark Brown <broonie@...nel.org>
To:	"Ivan T. Ivanov" <iivanov@...sol.com>
Cc:	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

On Fri, Mar 06, 2015 at 05:26:18PM +0200, Ivan T. Ivanov wrote:

> Ensure that driver is owner of the GPIO's used for CS signals.

> +	for (cs = 0; cs < master->num_chipselect; cs++) {
> +		cs_gpio = of_get_named_gpio(dev->of_node, "cs-gpios", cs);
> +

Any new GPIO users should really be using the gpiod API, however this is
duplicating core functionality so as Stephen says why are we doing this?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)