linux-kernel - Re: [PATCH][ASoC]Add DT bindings for generic ASoC AC97 CODEC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150307163102.GR28806@sirena.org.uk>
Date:	Sat, 7 Mar 2015 16:31:02 +0000
From:	Mark Brown <broonie@...nel.org>
To:	"Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Cc:	alsa-devel@...a-project.org, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Brian Austin <brian.austin@...rus.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][ASoC]Add DT bindings for generic ASoC AC97 CODEC driver

On Sat, Mar 07, 2015 at 04:33:12PM +0100, Maciej S. Szmigiero wrote:
> W dniu 07.03.2015 15:34, Mark Brown pisze:

> > That's true, and it's something it's easy to get away with with board
> > files, but that doesn't mean it's something we should be doing for
> > device tree where we're not just finding an expedient way to load things
> > but rather defining an ABI.

> Do you recommend then putting AC'97 bus/mixer attach in
> simple-card/fsl-asoc-card or controller driver instead?

It's tricky.  For the vast majority of AC'97 systems we probably want to
just do things from the bus controller but there are some funky AC'97
embedded systems out there which need quirks to varying degrees, and in
some cases the ASoC AC'97 drivers do a much better job on things like
power.  For those we'd need to do something different to just doing a
standard AC'97 instantiation but what exactly we do in a DT world (quirk
on machine compatible?) isn't clear.

If the platform you're working on isn't one that commonly got fancy
AC'97 subsystems then it's possibly best to just do the common case and
only worry about what to do about the complex case if anyone has a need.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)