linux-kernel - Re: [PATCH RESEND] Staging: rtl8188eu: fix double unlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54FB3523.7060600@lwfinger.net>
Date:	Sat, 07 Mar 2015 11:28:03 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Matteo Semenzato <mattew8898@...il.com>,
	gregkh@...uxfoundation.org, navin.patidar@...il.com,
	oat.elena@...il.com
CC:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] Staging: rtl8188eu: fix double unlock

On 03/07/2015 09:33 AM, Matteo Semenzato wrote:
> From: Matteo Semenzato <mattew8898@...il.com>
>
> The rtw_cmd_thread semaphore was being unlocked twice.
>
> Signed-off-by: Matteo Semenzato <mattew8898@...il.com>
> ---
>   drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c
> index 4b43462..43a8515 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
> @@ -173,7 +173,7 @@ int rtw_cmd_thread(void *context)
>   	allow_signal(SIGTERM);
>
>   	pcmdpriv->cmdthd_running = true;
> -	up(&pcmdpriv->terminate_cmdthread_sema);
> +	down(&pcmdpriv->terminate_cmdthread_sema);
>
>   	RT_TRACE(_module_rtl871x_cmd_c_, _drv_info_, ("start r871x rtw_cmd_thread !!!!\n"));

I get nervous when I see patch 2/2 immediately resent as a single patch. What is 
going on?

Have you actually tested this patch, or did you find this with some static checker?

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/