linux-kernel - Re: [patch 1/2] block, drbd: fix drbd_req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54FB98F3.2050308@fb.com>
Date:	Sat, 7 Mar 2015 17:33:55 -0700
From:	Jens Axboe <axboe@...com>
To:	David Rientjes <rientjes@...gle.com>,
	Lars Ellenberg <drbd-dev@...ts.linbit.com>
CC:	<linux-kernel@...r.kernel.org>, <drbd-user@...ts.linbit.com>
Subject: Re: [patch 1/2] block, drbd: fix drbd_req_new() initialization

On 03/07/2015 05:24 PM, David Rientjes wrote:
> mempool_alloc() does not support __GFP_ZERO since elements may come from
> memory that has already been released by mempool_free().
>
> Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly
> initialize it to 0.

You should add it to mempool instead, avoid having this issue show up 
for other folks as well. It'd be trivial to do. Normal ->alloc() should 
honor __GFP_ZERO, just do the same manually for removing an item from 
the internal pool.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/