linux-kernel - Re: [PATCH v2] staging: rtl8188eu: use %pM specifier instead of passing direct values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1425834052.5898.1.camel@perches.com>
Date:	Sun, 08 Mar 2015 10:00:52 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mike Krinkin <krinkin.m.u@...il.com>
Cc:	Larry.Finger@...inger.net, gregkh@...uxfoundation.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8188eu: use %pM specifier instead of
 passing direct values

On Sun, 2015-03-08 at 19:42 +0300, Mike Krinkin wrote:
> The patch converts code to use %pM specifier instead of pushing
> each byte via stack.

Hello Mike.

> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
[]
> @@ -1096,10 +1096,8 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo, bool
>  		memcpy(eeprom->mac_addr, &hwinfo[EEPROM_MAC_ADDR_88EU], ETH_ALEN);
>  	}
>  	RT_TRACE(_module_hci_hal_init_c_, _drv_notice_,
> -		 ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %02x-%02x-%02x-%02x-%02x-%02x\n",
> -		 eeprom->mac_addr[0], eeprom->mac_addr[1],
> -		 eeprom->mac_addr[2], eeprom->mac_addr[3],
> -		 eeprom->mac_addr[4], eeprom->mac_addr[5]));
> +		 ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %6phD\n",
> +		 eeprom->mac_addr));

You changed the subject and commit log but not
the patch.  V3?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/