linux-kernel - Re: [PATCH 1/2] i2c_imc: New driver for Intel's iMC, found on LGA2011 chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALCETrVv1_b2TH-jXkOYUVeJ812mOFz5HvfH-b1WuaHPP_tadw@mail.gmail.com>
Date:	Sun, 8 Mar 2015 12:55:58 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Jean Delvare <khali@...ux-fr.org>,
	Boaz Harrosh <boaz@...xistor.com>,
	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	Rui Wang <ruiv.wang@...il.com>,
	Alun Evans <alun@...gerous.net>,
	Robert Elliott <Elliott@...com>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	Wolfram Sang <wsa@...-dreams.de>,
	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	Tony Luck <tony.luck@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] i2c_imc: New driver for Intel's iMC, found on LGA2011 chips

On Sun, Mar 8, 2015 at 12:50 PM, Guenter Roeck <linux@...ck-us.net> wrote:
> On 03/08/2015 12:30 PM, Andy Lutomirski wrote:
> [ ... ]
>
>>>
>>>> One other question: from my reading of the spec, it should be possible
>>>> to
>>>> augment this driver to expose a temporate sensor subdevice that shows
>>>> recent cached temperatures from HW DIMM measurements.  They would be
>>>> redundant with the jc42 outputs, but it would be safe to use them even
>>>> on
>>>> systems without safe SMBUS arbitration.  Should I do that as a followup
>>>> later on?
>>>>
>>>
>>> Without thinking too much about it, this should be a separate driver,
>>> and I think it might actually be more valuable (since less risky)
>>> than this entire patch set.
>>
>>
>> The main problem there is that they'll fight over the PCI ids.
>>
> That is why we have mfd drivers. While that most likely won't be a
> solution here (and I don't suggest it), you can use the same idea.
> If can not be instantiated as pci driver, the alternative would be
> to instantiate it as platform driver and let it get its pci
> information from the parent device.
>

Hmm.  It could make sense to have an Intel chipset driver that
instantiates sub-devices for thermal monitoring, smbus, and EDAC.  It
might be a bit of a cleanup for sb-edac, too.

Anyway, this isn't currently necessary.  Let's deal with it when we get there.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/