linux-kernel - Re: [RFC PATCH] spi: Ensure that CS line is in non-active state after setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150308200142.GC28806@sirena.org.uk>
Date:	Sun, 8 Mar 2015 20:01:42 +0000
From:	Mark Brown <broonie@...nel.org>
To:	"Ivan T. Ivanov" <iivanov@...sol.com>
Cc:	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [RFC PATCH] spi: Ensure that CS line is in non-active state
 after setup

On Fri, Mar 06, 2015 at 05:45:15PM +0200, Ivan T. Ivanov wrote:

>  	if (spi->master->setup)
>  		status = spi->master->setup(spi);
> +	else
> +		spi_set_cs(spi, false);

Why would this be conditional on there not being a setup operation?
It's a good idea, I just don't see why the backstop isn't always useful.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)