linux-kernel - Re: [PATCH 3/3] staging: lustre: space required after that close brace '}'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1425848020.5898.13.camel@perches.com>
Date:	Sun, 08 Mar 2015 13:53:40 -0700
From:	Joe Perches <joe@...ches.com>
To:	Alberto Pires de Oliveira Neto <mrpenguin2005@...il.com>
Cc:	oleg.drokin@...el.com, andreas.dilger@...el.com,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] staging: lustre: space required after that close
 brace '}'

On Sun, 2015-03-08 at 17:43 -0300, Alberto Pires de Oliveira Neto wrote:
> This patch fixes checkpatch.pl warning.
> WARNING: space required after that close brace '}'
> 
> Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@...il.com>
> ---
>  drivers/staging/lustre/lustre/fld/lproc_fld.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c b/drivers/staging/lustre/lustre/fld/lproc_fld.c
> index 8c5a657..3235194 100644
> --- a/drivers/staging/lustre/lustre/fld/lproc_fld.c
> +++ b/drivers/staging/lustre/lustre/fld/lproc_fld.c
> @@ -168,4 +168,4 @@ struct lprocfs_vars fld_client_proc_list[] = {
>  	{ "targets", &fld_proc_targets_fops },
>  	{ "hash", &fld_proc_hash_fops },
>  	{ "cache_flush", &fld_proc_cache_flush_fops },
> -	{ NULL }};
> +	{ NULL } };

The generally preferred form would be:

struct lprocfs_vars fld_client_proc_list[] = {
	{ "targets", &fld_proc_targets_fops },
	{ "hash", &fld_proc_hash_fops },
	{ "cache_flush", &fld_proc_cache_flush_fops },
	{ NULL }
};

though that "{ NULL }" is just more commonly "{},"

And it's probably better to remove this from the .h
file and this file and move it to the one place it's
actually used and make it static (const too eventually)

$ git grep -w fld_client_proc_list
drivers/staging/lustre/lustre/fld/fld_internal.h:extern struct lprocfs_vars fld_client_proc_list[];
drivers/staging/lustre/lustre/fld/fld_request.c:                              fld_client_proc_list, fld);
drivers/staging/lustre/lustre/fld/lproc_fld.c:struct lprocfs_vars fld_client_proc_list[] = {


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/