linux-kernel - Re: [PATCH] i8042 / PM: Allow PC keyboard to wake up from suspend-to-idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3127745.ybR8YAlvTb@vostro.rjw.lan>
Date:	Mon, 09 Mar 2015 23:41:12 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Kristen Carlson Accardi <kristen@...ux.intel.com>,
	Linux PM list <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-input@...r.kernel.org
Subject: Re: [PATCH] i8042 / PM: Allow PC keyboard to wake up from suspend-to-idle

On Monday, March 09, 2015 11:00:04 AM Dmitry Torokhov wrote:
> Hi Rafael,
> 
> On Mon, Mar 09, 2015 at 04:19:50PM +0100, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > 
> > If they keyboard interrupt is registered, mark the i8042 platform
> > device as wakeup-capable and check the user space wakeup setting in
> > i8042_pm_suspend() and i8042_pm_resume() to enable or disable,
> > respectively, the keyboard interrupt to wake up the system.
> > 
> > This makes it possible to use the PC keyboard to wake up the system
> > from suspend-to-idle after writing "enabled" to the i8042 device's
> > power/wakeup sysfs attribute.
> 
> Why do we do that for KBD but not AUX port? Should we mark individual
> serio port be wakeup capable and not the whole i8042.

We can do that, but only after the port serio device has been registered.

I guess I can add code for that to i8042_register_ports().  Let me try that.

> Also, why exactly is this needed? My laptops seem to resume just fine
> from keyboard activity without this patch...

Mine don't.  At least not from suspend-to-idle ("echo freeze > /sys/power/state").

Whether or not the PC keyboard wakes them up from suspend-to-RAM depends on the
BIOS.  That only works for one of my laptops, but this patch doesn't help here.

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/