linux-kernel - Re: [PATCH v3 5/7] selftests/timers: Use implicit rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54FE29F7.2050803@osg.samsung.com>
Date:	Mon, 09 Mar 2015 17:17:11 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Michael Ellerman <mpe@...erman.id.au>
CC:	linux-kernel@...r.kernel.org, davej@...emonkey.org.uk,
	mmarek@...e.cz, linux-api@...r.kernel.org
Subject: Re: [PATCH v3 5/7] selftests/timers: Use implicit rules

On 03/04/2015 03:41 AM, Michael Ellerman wrote:
> There's no need to open-code the build rules, use the implicit ones.
> 
> This has the nice side effect of enabling cross compilation.
> 
> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
> ---
>  tools/testing/selftests/timers/Makefile | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile
> index 149cee3b7b8a..87340405e4b3 100644
> --- a/tools/testing/selftests/timers/Makefile
> +++ b/tools/testing/selftests/timers/Makefile
> @@ -1,9 +1,9 @@
> -all:
> -	gcc posix_timers.c -o posix_timers -lrt
> -
>  TEST_PROGS := posix_timers
> +LDLIBS += -lrt
> +
> +all: $(TEST_PROGS)

I can't take this patch. This breaks make kselftest
run. With this change timers test fails to build

make[2]: Nothing to be done for 'all'.
make[2]: *** No rule to make target 'posix_timers', needed by 'all'.  Stop.


thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/