linux-kernel - Re: [PATCH] serial: 8250: remove the redundant include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54FD1C2A.2070703@huawei.com>
Date:	Mon, 9 Mar 2015 12:06:02 +0800
From:	"long.wanglong" <long.wanglong@...wei.com>
To:	Wang Long <long.wanglong@...wei.com>
CC:	<gregkh@...uxfoundation.org>, <jslaby@...e.cz>,
	<bigeasy@...utronix.de>, <peter@...leysoftware.com>,
	<tony@...mide.com>, <alan@...ux.intel.com>,
	<ricardo.ribalda@...il.com>, <yoshihiro.yunomae.ez@...achi.com>,
	<andriy.shevchenko@...ux.intel.com>, <robh@...nel.org>,
	<Vineet.Gupta1@...opsys.com>, <wsa@...-dreams.de>,
	<dforsi@...il.com>, <rafael.j.wysocki@...el.com>,
	<linux-serial@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<peifeiyue@...wei.com>
Subject: Re: [PATCH] serial: 8250: remove the redundant include

On 2015/3/9 12:12, Wang Long wrote:
> The serial_core.h file have been included in header file
> serial_8250.h. so remove the "#include <serial_core.h>" in
> some 8250 serial drivers, because they have included the header file
> serial_8250.h.

missing the 8250_dw.c. i will send another patch.

Thanks
> 
> Signed-off-by: Wang Long <long.wanglong@...wei.com>
> ---
>  drivers/tty/serial/8250/8250_core.c  | 1 -
>  drivers/tty/serial/8250/8250_early.c | 1 -
>  drivers/tty/serial/8250/8250_em.c    | 1 -
>  drivers/tty/serial/8250/8250_hp300.c | 1 -
>  drivers/tty/serial/8250/8250_omap.c  | 1 -
>  5 files changed, 5 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index e3b9570a..7ddd668 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -31,7 +31,6 @@
>  #include <linux/tty.h>
>  #include <linux/ratelimit.h>
>  #include <linux/tty_flip.h>
> -#include <linux/serial_core.h>
>  #include <linux/serial.h>
>  #include <linux/serial_8250.h>
>  #include <linux/nmi.h>
> diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c
> index c31a22b..c7ae647 100644
> --- a/drivers/tty/serial/8250/8250_early.c
> +++ b/drivers/tty/serial/8250/8250_early.c
> @@ -29,7 +29,6 @@
>  #include <linux/tty.h>
>  #include <linux/init.h>
>  #include <linux/console.h>
> -#include <linux/serial_core.h>
>  #include <linux/serial_reg.h>
>  #include <linux/serial.h>
>  #include <linux/serial_8250.h>
> diff --git a/drivers/tty/serial/8250/8250_em.c b/drivers/tty/serial/8250/8250_em.c
> index ae5eaed..0b63812 100644
> --- a/drivers/tty/serial/8250/8250_em.c
> +++ b/drivers/tty/serial/8250/8250_em.c
> @@ -21,7 +21,6 @@
>  #include <linux/io.h>
>  #include <linux/module.h>
>  #include <linux/serial_8250.h>
> -#include <linux/serial_core.h>
>  #include <linux/serial_reg.h>
>  #include <linux/platform_device.h>
>  #include <linux/clk.h>
> diff --git a/drivers/tty/serial/8250/8250_hp300.c b/drivers/tty/serial/8250/8250_hp300.c
> index b488208..2891958 100644
> --- a/drivers/tty/serial/8250/8250_hp300.c
> +++ b/drivers/tty/serial/8250/8250_hp300.c
> @@ -10,7 +10,6 @@
>  #include <linux/string.h>
>  #include <linux/kernel.h>
>  #include <linux/serial.h>
> -#include <linux/serial_core.h>
>  #include <linux/serial_8250.h>
>  #include <linux/delay.h>
>  #include <linux/dio.h>
> diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
> index fe6d2e51..9289999 100644
> --- a/drivers/tty/serial/8250/8250_omap.c
> +++ b/drivers/tty/serial/8250/8250_omap.c
> @@ -11,7 +11,6 @@
>  #include <linux/io.h>
>  #include <linux/module.h>
>  #include <linux/serial_8250.h>
> -#include <linux/serial_core.h>
>  #include <linux/serial_reg.h>
>  #include <linux/tty_flip.h>
>  #include <linux/platform_device.h>
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/