linux-kernel - Re: [PATCH v2 1/3] drm: bridge/dw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1425876496.2745.21.camel@perches.com>
Date:	Sun, 08 Mar 2015 21:48:16 -0700
From:	Joe Perches <joe@...ches.com>
To:	Yakir Yang <ykk@...k-chips.com>
Cc:	David Airlie <airlied@...ux.ie>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Philipp Zabel <p.zabel@...gutronix.de>, djkurtz@...omium.org,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Shawn Guo <shawn.guo@...aro.org>,
	Rob Clark <robdclark@...il.com>,
	Mark Yao <mark.yao@...k-chips.com>,
	Daniel Vetter <daniel@...ll.ch>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	Andy Yan <andy.yan@...k-chips.com>, mmind00@...glemail.com,
	dianders@...omium.org, marcheu@...omium.org,
	linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v2 1/3] drm: bridge/dw_hdmi: fixed codec style

On Mon, 2015-03-09 at 12:42 +0800, Yakir Yang wrote:
> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
[]
> @@ -900,10 +900,10 @@ static int hdmi_phy_configure(struct dw_hdmi *hdmi, unsigned char prep,
>  {
>  	unsigned res_idx, i;
>  	u8 val, msec;
> -	const struct dw_hdmi_mpll_config *mpll_config =
> -						hdmi->plat_data->mpll_cfg;
> -	const struct dw_hdmi_curr_ctrl *curr_ctrl = hdmi->plat_data->cur_ctr;
> -	const struct dw_hdmi_sym_term *sym_term =  hdmi->plat_data->sym_term;
> +	const struct dw_hdmi_plat_data *plat_data = hdmi->plat_data;
> +	const struct dw_hdmi_mpll_config *mpll_config = plat_data->mpll_cfg;
> +	const struct dw_hdmi_curr_ctrl *curr_ctrl = plat_data->cur_ctr;
> +	const struct dw_hdmi_sym_term *sym_term =  plat_data->sym_term;
>  
>  	if (prep)
>  		return -EINVAL;

Shouldn't all of these be static?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/