linux-kernel - Re: [PATCH 1/3] phy: omap-control: Remove unneeded ifdef CONFIG_OF guard and of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 9 Mar 2015 10:41:16 +0530
From:	Kishon Vijay Abraham I <kishon@...com>
To:	Roger Quadros <rogerq@...com>, Axel Lin <axel.lin@...ics.com>
CC:	Vignesh R <vigneshr@...com>, Felipe Balbi <balbi@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] phy: omap-control: Remove unneeded ifdef CONFIG_OF
 guard and of_match_ptr

Hi,

On Friday 06 March 2015 03:36 PM, Roger Quadros wrote:
> On 05/03/15 17:29, Axel Lin wrote:
>> 2015-03-05 18:48 GMT+08:00 Roger Quadros <rogerq@...com>:
>>> Hi Alex,
>> It's Axel.
>
> My apologies Axel.
>
>>
>>>
>>> Since we're anyways going to fail probe for !CONFIG_OF, why do you want to
>>> add the unnecessary device table to the kernel?
>>>
>>> what are you benefiting from this change?
>>
>> If the driver works for both dt case and non-dt case, using the ifdef CONFIG_OF
>> guard can save a few memory for non-dt case.
>> For dt-only  driver it is not required because you cannot use the driver
>> if !CONFIG_OF. Which means you should not build this driver at all if !CONFIG_OF
>> unless you just want to do compile test.
>
> I agree. Kishon do we really need to build these drivers if !CONFIG_OF?

We can stop building these drivers for !CONFIG_OF since none of the platforms
which uses these drivers support non-dt anyway.

Cheers
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/