linux-kernel - Re: [PATCH v4 2/6] Input: synaptics - Log queried and quirked dimension values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150309064312.GB17331@dtor-ws>
Date:	Sun, 8 Mar 2015 23:43:12 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:	Daniel Martin <consume.noise@...il.com>,
	Hans de Goede <hdegoede@...hat.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/6] Input: synaptics - Log queried and quirked
 dimension values

On Fri, Feb 06, 2015 at 10:44:55AM -0500, Benjamin Tissoires wrote:
> From: Daniel Martin <consume.noise@...il.com>
> 
> Logging the dimension values we queried (info) and the values we use
> from a quirk to overwrite (warn) can be helpful for debugging.

Warnings should be sed when something goes wrong, not during normal
operations. Switched all to info and merged split strings.

Thanks.

> 
> This partly relates to bug:
>     https://bugzilla.kernel.org/show_bug.cgi?id=91541
> 
> Cc: stable@...r.kernel.org
> Signed-off-by: Daniel Martin <consume.noise@...il.com>
> ---
>  drivers/input/mouse/synaptics.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 8c2b343..0485e6b 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -365,6 +365,10 @@ static int synaptics_resolution(struct psmouse *psmouse)
>  		} else {
>  			priv->x_max = (resp[0] << 5) | ((resp[1] & 0x0f) << 1);
>  			priv->y_max = (resp[2] << 5) | ((resp[1] & 0xf0) >> 3);
> +			psmouse_info(psmouse,
> +				     "queried max coordinates: "
> +				     "x [..%d], y [..%d]\n",
> +				     priv->x_max, priv->y_max);
>  		}
>  	}
>  
> @@ -376,6 +380,10 @@ static int synaptics_resolution(struct psmouse *psmouse)
>  		} else {
>  			priv->x_min = (resp[0] << 5) | ((resp[1] & 0x0f) << 1);
>  			priv->y_min = (resp[2] << 5) | ((resp[1] & 0xf0) >> 3);
> +			psmouse_info(psmouse,
> +				     "queried min coordinates: "
> +				     "x [%d..], y [%d..]\n",
> +				     priv->x_min, priv->y_min);
>  		}
>  	}
>  
> @@ -398,6 +406,11 @@ static int synaptics_quirks(struct psmouse *psmouse)
>  			priv->x_max = min_max_pnpid_table[i].x_max;
>  			priv->y_min = min_max_pnpid_table[i].y_min;
>  			priv->y_max = min_max_pnpid_table[i].y_max;
> +			psmouse_warn(psmouse,
> +				     "quirked min/max coordinates: "
> +				     "x [%d..%d], y [%d..%d]\n",
> +				     priv->x_min, priv->x_max,
> +				     priv->y_min, priv->y_max);
>  			break;
>  		}
>  	}
> -- 
> 2.1.0
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/