linux-kernel - Re: [PATCH 3/4] perf, tools, stat: Fix IPC and other formulas with -A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150309081158.GC27885@krava.brq.redhat.com>
Date:	Mon, 9 Mar 2015 09:11:58 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	acme@...nel.org, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 3/4] perf, tools, stat: Fix IPC and other formulas with -A

On Sun, Mar 08, 2015 at 04:55:23PM -0700, Andi Kleen wrote:

SNIP

> -		update_stats(&runtime_dtlb_cache_stats[ctx][0], count[0]);
> +		update_stats(&runtime_dtlb_cache_stats[ctx][cpu], count[0]);
>  	else if (perf_evsel__match(counter, HW_CACHE, HW_CACHE_ITLB))
> -		update_stats(&runtime_itlb_cache_stats[ctx][0], count[0]);
> +		update_stats(&runtime_itlb_cache_stats[ctx][cpu], count[0]);
>  }
>  
>  static void zero_per_pkg(struct perf_evsel *counter)
> @@ -463,7 +464,8 @@ static int read_cb(struct perf_evsel *evsel, int cpu, int thread __maybe_unused,
>  			perf_evsel__compute_deltas(evsel, cpu, count);
>  		perf_counts_values__scale(count, scale, NULL);
>  		evsel->counts->cpu[cpu] = *count;
> -		update_shadow_stats(evsel, count->values);
> +		if (aggr_mode == AGGR_NONE)
> +			update_shadow_stats(evsel, count->values, cpu);

this will also prevent the 'socket' and 'core' aggregation
not to print bogus data for socket/core cpu 0, we'll need
to aggregate shadow stats first to support that.. anyway:

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/