linux-kernel - Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150309101012.GA3914@earth>
Date:	Mon, 9 Mar 2015 11:10:12 +0100
From:	Sebastian Reichel <sre@...nel.org>
To:	Beomho Seo <beomho.seo@...sung.com>
Cc:	broonie@...nel.org, robh+dt@...nel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
	lee.jones@...aro.org, cw00.choi@...sung.com,
	sangbae90.lee@...sung.com, inki.dae@...sung.com,
	sw0312.kim@...sung.com,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device
 driver

Hi,

On Mon, Mar 09, 2015 at 01:53:58PM +0900, Beomho Seo wrote:
> >> remove the special handling of POWER_SUPPLY_PROP_CURRENT_MAX in 
> >> rt5033_get_charger_current() and do it like this:
> >>
> >> case POWER_SUPPLY_PROP_CURRENT_NOW:
> >>     val->intval = rt5033_get_charger_current(charger);
> >>     break;
> >> case POWER_SUPPLY_PROP_CURRENT_MAX:
> >>     val->intval = RT5033_CHG_MAX_CURRENT;
> >>     break;
> >>
> > 
> > OK. I will change comply with your comment.
> > 
> 
> RT5033_CHG_MAX_CURRENT is register value(hex).
> So It is better:
> 
> case POWER_SUPPLY_PROP_CURRENT_MAX:
> 	val->intval = RT5033_CHARGER_FAST_CURRENT_MAX;
> 
> And then I will fix rt5033_get_charger_current function more readable.

Right, I copied the wrong value.

> [...]

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)