linux-kernel - Re: [PATCH_V2] ASoC: jz4740: Add jz4780 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54FD8A0A.4080909@metafoo.de>
Date:	Mon, 09 Mar 2015 12:54:50 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>,
	broonie@...nel.org, lgirdwood@...il.com
CC:	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH_V2] ASoC: jz4740: Add jz4780 support

On 03/09/2015 12:23 PM, Zubair Lutfullah Kakakhel wrote:
[...]
> @@ -460,6 +499,9 @@ static int jz4740_i2s_dev_probe(struct platform_device *pdev)
>
>   	platform_set_drvdata(pdev, i2s);
>
> +	if (i2s->version >= JZ_I2S_JZ4780)
> +		jz4740_i2s_dai.symmetric_rates = 0;

We shouldn't modify driver global structs from a device instance. Just add a 
second copy of jz4740_i2s_dai for the jz4780 without the bit set.

- Lars

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/