linux-kernel - Re: [PATCH] net: smc91x: improve neponset hack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 Mar 2015 12:34:47 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	netdev@...r.kernel.org, Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org, davem@...emloft.net,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] net: smc91x: improve neponset hack

On Mon, Mar 09, 2015 at 12:20:12PM +0000, Russell King - ARM Linux wrote:
> On Fri, Feb 20, 2015 at 04:47:06PM +0100, Arnd Bergmann wrote:
> > On Thursday 19 February 2015 00:35:49 Russell King - ARM Linux wrote:
> > > On Wed, Feb 18, 2015 at 08:47:30PM +0100, Arnd Bergmann wrote:
> > > > The smc91x driver tries to support multiple platforms at compile
> > > > time, but they are mutually exclusive at runtime, and not clearly
> > > > defined.
> > > 
> > > I'd prefer to rework this to fix that properly.  From what I remember,
> > > the whole SA11x0 stuff in this driver was a mess.
> > 
> > I guess that's reasonable. I've looked through the driver and it seems we
> > did most of the multiplatform work but left a few things alone that should
> > have been converted a long time ago.
> > 
> > Can you check if the approach below makes sense to you?
> 
> I don't know who's carrying what patches, but this is still broken.
> 
> arch/arm/mach-sa1100/neponset.c: In function 'neponset_probe':
> arch/arm/mach-sa1100/neponset.c:271:12: error: 'smc91c_platdata' undeclared (first use in this function)
> drivers/net/ethernet/smsc/smc91x.c: In function 'smc_drv_probe':
> drivers/net/ethernet/smsc/smc91x.c:2363:2: error: implicit declaration of function 'machine_has_neponset' [-Werror=implicit-function-declaration]
> 
> This is from building Linus' tree as of Saturday plus arm-soc.
> 
> Let's revert all this crap and start again, this time testing it better?

I'm also getting:

arch/arm/mach-pxa/idp.c:84:15: error: variable 'smc91x_platdata' has initializer but incomplete type
arch/arm/mach-pxa/idp.c:85:2: error: unknown field 'flags' specified in initializer
arch/arm/mach-pxa/idp.c:85:11: error: 'SMC91X_USE_32BIT' undeclared here (not in a function)
arch/arm/mach-pxa/idp.c:85:30: error: 'SMC91X_USE_DMA' undeclared here (not in a function)
arch/arm/mach-pxa/idp.c:85:47: error: 'SMC91X_NOWAIT' undeclared here (not in a function)
arch/arm/mach-pxa/idp.c:85:2: warning: excess elements in struct initializer [enabled by default]
arch/arm/mach-pxa/idp.c:85:2: warning: (near initialization for 'smc91x_platdata') [enabled by default]
arch/arm/mach-pxa/lpd270.c:198:30: error: expected '}' before ';' token


-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/