linux-kernel - Re: [PATCH] phy: berlin-sata: Use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150309130246.GA8421@kwain>
Date:	Mon, 9 Mar 2015 14:02:46 +0100
From:	Antoine Tenart <antoine.tenart@...e-electrons.com>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Kishon Vijay Abraham I <kishon@...com>,
	Antoine Tenart <antoine.tenart@...e-electrons.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: berlin-sata: Use devm_kcalloc at appropriate place

On Thu, Mar 05, 2015 at 09:40:41AM +0800, Axel Lin wrote:
> Prefer devm_kcalloc over devm_kzalloc with multiply.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Acked-by: Antoine Tenart <antoine.tenart@...e-electrons.com>

> ---
>  drivers/phy/phy-berlin-sata.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/phy-berlin-sata.c b/drivers/phy/phy-berlin-sata.c
> index 099eee8..6f3e06d 100644
> --- a/drivers/phy/phy-berlin-sata.c
> +++ b/drivers/phy/phy-berlin-sata.c
> @@ -218,7 +218,7 @@ static int phy_berlin_sata_probe(struct platform_device *pdev)
>  	if (priv->nphys == 0)
>  		return -ENODEV;
>  
> -	priv->phys = devm_kzalloc(dev, priv->nphys * sizeof(*priv->phys),
> +	priv->phys = devm_kcalloc(dev, priv->nphys, sizeof(*priv->phys),
>  				  GFP_KERNEL);
>  	if (!priv->phys)
>  		return -ENOMEM;
> -- 
> 1.9.1
> 
> 
> 

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/