linux-kernel - Re: [PATCH 1/4] perf, tools: Output running time and run/enabled ratio in CSV mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150309140434.GG31334@tassilo.jf.intel.com>
Date:	Mon, 9 Mar 2015 07:04:34 -0700
From:	Andi Kleen <ak@...ux.intel.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Andi Kleen <andi@...stfloor.org>, acme@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] perf, tools: Output running time and run/enabled
 ratio in CSV mode

> hum, so people using CSV mode will now see extra 2 numbers
> at the end of the line:
> 
>   $ ./perf.old stat -x, -e cycles ls > /dev/null
>   2679161,,cycles
>   $ ./perf stat -x, -e cycles ls > /dev/null
>   2574169,,cycles,1295544,100.00
> 
> we could be breaking existing scripts..

I doubt it. Typical CSV parsers ignore additional data at the end.

Just don't insert stuff in the middle (like it was done recently).
That breaks a lot of things.

> you recently added 'running-time' option for record,
> could you please add same option for stat?

Could be done, but I'm not sure it's worth it here.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/