linux-kernel - Re: [PATCH v2] i2c: designware: Suppress error message if platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OFBD47D4C1.937484E0-ONC1257E03.005AABCB-C1257E03.005B051D@alitech.com>
Date:	Mon, 9 Mar 2015 17:34:51 +0100
From:	christian.ruppert@...tech.com
To:	Alexey Brodkin <Alexey.Brodkin@...opsys.com>
Cc:	Alexey Brodkin <Alexey.Brodkin@...opsys.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Christian Ruppert <christian.ruppert@...lis.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Vineet Gupta <Vineet.Gupta1@...opsys.com>,
	Wolfram Sang <wsa@...-dreams.de>
Subject: Re: [PATCH v2] i2c: designware: Suppress error message if platform_get_irq() < 0

Alexey Brodkin <Alexey.Brodkin@...opsys.com> wrote on 03/09/2015 10:03:12 
AM:

> From: Alexey Brodkin <Alexey.Brodkin@...opsys.com>
> To: linux-i2c@...r.kernel.org, 
> Cc: linux-kernel@...r.kernel.org, Alexey Brodkin 
> <Alexey.Brodkin@...opsys.com>, Vineet Gupta 
> <Vineet.Gupta1@...opsys.com>, Christian Ruppert 
> <christian.ruppert@...lis.com>, Mika Westerberg 
> <mika.westerberg@...ux.intel.com>, Wolfram Sang <wsa@...-dreams.de>,
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Date: 03/09/2015 10:03 AM
> 
> As discussed here https://lkml.org/lkml/2015/3/3/568 and here
> https://lkml.org/lkml/2015/3/3/453 we're looking forward for
> implementing warnings and errors outputs right in platform_get_irq()
> instead of having all kind of different outputs in each and every driver
> that uses platform_get_irq().
> 
> Signed-off-by: Alexey Brodkin <abrodkin@...opsys.com>
> Cc: Vineet Gupta <vgupta@...opsys.com>
> Cc: Christian Ruppert <christian.ruppert@...lis.com>
Acked-by: Christian Ruppert <christian.ruppert@...tech.com>

Please note that my email address has changed and use the alitech one in 
future. The abilis address might be switched off soon.

> Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>
> Cc: Wolfram Sang <wsa@...-dreams.de>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/i2c/busses/i2c-designware-platdrv.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/
> i2c/busses/i2c-designware-platdrv.c
> index c270f5f..fa4e2b5 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -143,10 +143,8 @@ static int dw_i2c_probe(struct platform_device 
*pdev)
>     u32 clk_freq, ht = 0;
> 
>     irq = platform_get_irq(pdev, 0);
> -   if (irq < 0) {
> -      dev_err(&pdev->dev, "no irq resource?\n");
> -      return irq; /* -ENXIO */
> -   }
> +   if (irq < 0)
> +      return irq;
> 
>     dev = devm_kzalloc(&pdev->dev, sizeof(struct dw_i2c_dev), 
GFP_KERNEL);
>     if (!dev)
> -- 
> 2.1.0
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/