linux-kernel - Re: [PATCH v2] Remove deprecated IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150309172907.GO3739@saruman.tx.rr.com>
Date:	Mon, 9 Mar 2015 12:29:07 -0500
From:	Felipe Balbi <balbi@...com>
To:	Valentin Rothberg <valentinrothberg@...il.com>
CC:	<balbi@...com>, <akpm@...ux-foundation.org>,
	Jonathan Corbet <corbet@....net>,
	Ralf Baechle <ralf@...ux-mips.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Paul Bolle <pebolle@...cali.nl>, Jiri Kosina <jkosina@...e.cz>,
	Hannes Reinecke <hare@...e.de>, Ewan Milne <emilne@...hat.com>,
	Christoph Hellwig <hch@....de>,
	Hongliang Tao <taohl@...ote.com>,
	Huacai Chen <chenhc@...ote.com>, Nishanth Menon <nm@...com>,
	Peter Ujfalusi <peter.ujfalusi@...com>,
	Tony Lindgren <tony@...mide.com>,
	Afzal Mohammed <afzal@...com>, Keerthy <j-keerthy@...com>,
	Zhou Wang <wangzhou1@...ilicon.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Quentin Lambert <lambert.quentin@...il.com>,
	Arnd Bergmann <arnd@...db.de>, Ingo Molnar <mingo@...nel.org>,
	Eyal Perry <eyalpe@...lanox.com>,
	Peter Zijlstra <peterz@...radead.org>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-mips@...ux-mips.org>, <iss_storagedev@...com>,
	<linux-mtd@...ts.infradead.org>, <linux-usb@...r.kernel.org>
Subject: Re: [PATCH v2] Remove deprecated IRQF_DISABLED flag entirely

On Mon, Mar 09, 2015 at 06:24:29PM +0100, Valentin Rothberg wrote:
> On Mon, Mar 9, 2015 at 5:52 PM, Felipe Balbi <balbi@...com> wrote:
> > Hi,
> >
> > On Thu, Mar 05, 2015 at 03:23:08PM +0100, Valentin Rothberg wrote:
> >> The IRQF_DISABLED is a NOOP and has been scheduled for removal since
> >> Linux v2.6.36 by commit 6932bf37bed4 ("genirq: Remove IRQF_DISABLED from
> >> core code").
> >>
> >> According to commit e58aa3d2d0cc ("genirq: Run irq handlers with
> >> interrupts disabled") running IRQ handlers with interrupts enabled can
> >> cause stack overflows when the interrupt line of the issuing device is
> >> still active.
> >>
> >> This patch ends the grace period for IRQF_DISABLED (i.e., SA_INTERRUPT
> >> in older versions of Linux) and removes the definition and all remaining
> >> usages of this flag.
> >>
> >> Signed-off-by: Valentin Rothberg <valentinrothberg@...il.com>
> >> ---
> >> The bigger hunk in Documentation/scsi/ncr53c8xx.txt is removed entirely
> >> as IRQF_DISABLED is gone now; the usage in older kernel versions
> >> (including the old SA_INTERRUPT flag) should be discouraged.  The
> >> trouble of using IRQF_SHARED is a general problem and not specific to
> >> any driver.
> >>
> >> I left the reference in Documentation/PCI/MSI-HOWTO.txt untouched since
> >> it has already been removed in linux-next by commit b0e1ee8e1405
> >> ("MSI-HOWTO.txt: remove reference on IRQF_DISABLED").
> >>
> >> All remaining references are changelogs that I suggest to keep.
> >>
> >> Changelog
> >>
> >> v2: Correct previous change to drivers/mtd/nand/hisi504_nand.c that
> >> broke compilation.  Reported by Dan Carpenter.
> >> ---
> >>  drivers/usb/isp1760/isp1760-core.c   |  3 +--
> >>  drivers/usb/isp1760/isp1760-udc.c    |  4 ++--
> >
> > I have a commit in my tree for isp1760:
> >
> > https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/fixes&id=80b4a0f8feeb6ee7fa4430a2b4ae1155ed923bd2
> 
> I am sorry, but I did not receive an email that it has been applied.
> Andrew asked me to do this patch, so I replied to the one you
> mentioned to avoid this conflict:

it's still in my testing/fixes, it'll be moved to fixes after I finish
testing that branch, then you'll receive an email

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)